Make logging a pluggable component of Protobuf #210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This refactors logging to make the logger a pluggable component of Protobuf. The logger can be changed by using `::Protobuf::Logging.logger = new_logger`. Any object that complies with the API of the ruby standard logger may be used. All the spec's in spec/lib are passing. I had some errors in the zmq library when trying to run the others. I also uncovered a bug that appears when running specs with DEBUG=1. The `RequestDecoder` and the `ResponseDecoder` referred to `env.signature` when they should have been referring to `env.log_signature`. That is now fixed. I used the logging in [mperham's sidekiq](https://github.com/mperham/sidekiq) as a reference.
|
This looks fine to me. Good work dude. 👍 |
|
Definitely a fan of this. 👍 |
abrandoned
added a commit
that referenced
this pull request
Aug 26, 2014
Make logging a pluggable component of Protobuf
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This refactors logging to make the logger a pluggable component of
Protobuf. The logger can be changed by using
::Protobuf::Logging.logger = new_logger. Any object that complies withthe API of the ruby standard logger may be used.
All the spec's in spec/lib are passing. I had some errors in the zmq
library when trying to run the others. I also uncovered a bug that
appears when running specs with DEBUG=1. The
RequestDecoderand theResponseDecoderreferred toenv.signaturewhen they should have beenreferring to
env.log_signature. That is now fixed.I used the logging in mperham's sidekiq as a reference.
RFC @localshred @abrandoned